[U-Boot] [PATCH v8] Marvell Kirkwood family SOC support

[Prafulla Wadaskar]

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de 
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Prafulla Wadaskar
> Sent: Wednesday, May 20, 2009 2:30 PM
> To: Wolfgang Denk
> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; 
> Ronen Shitrit
> Subject: Re: [U-Boot] [PATCH v8] Marvell Kirkwood family SOC support
> 
> Dear Wolfgand Denk
> 
> Thanks for your review comments 
> 
> > -----Original Message-----
> > From: Wolfgang Denk [mailto:wd at denx.de]
> > Sent: Wednesday, May 20, 2009 3:29 AM
> > To: Prafulla Wadaskar
> > Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen 
> > Shitrit
> > Subject: Re: [U-Boot] [PATCH v8] Marvell Kirkwood family SOC support
> > 
> > Dear Prafulla Wadaskar,
> > 
> > In message
> > <1242763678-13724-1-git-send-email-prafulla at marvell.com> you wrote:
> > > 
> > > Kirkwood family controllers are highly integrated SOCs based on
> > > Feroceon-88FR131/Sheeva-88SV131 cpu core.
> > ...
> > > +/*
> > > + * Window Size
> > > + * Used with the Base register to set the address window
> > size and location.
> > > + * Must be programmed from LSB to MSB as sequence of 1’s
> > followed
> > > +by
> > > + * sequence of 0’s. The number of 1’s specifies the
> > size of the
> > > +window in
> > > + * 64 KByte granularity (e.g., a value of 0x00FF specifies
> > 256 = 16 MByte).
> > > + * NOTE: A value of 0x0 specifies 64-KByte size.
> > > + */
> > 
> > You have a number of strange special characters here. 
> Please try and 
> > restrict yourself to plain ASCII text in normal C comments.
> I checked the patch that I send across and associated source code too.
> I didn’t find the above special chars in it I am using 
> git-send-email to send the patches and vim as my editor I 
> wonder how these special characters appeared in the patch !!!!
> I will check this issue with my system admin
Hi Wolfgang Denk
We have discovered the root cause of this problem
I was using apostrophes, those were getting converted to weird 
characters by the mailer software (just a guess).
I have replaced then with strings (i.e. "1's" with "ones" and "0's" with "zeros")
Of course I will not release a new patch (V11) for this :-)
but I have corrected at my end and will reflect in next patch after review feedback for V10

Thanks for pointing this...

Regards..
Prafulla . .