[U-Boot] [PATCH v10] Marvell MV88F6281GTW_GE Board support

[Prafulla Wadaskar]

> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de] 
> Sent: Friday, May 22, 2009 4:37 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; 
> Ronen Shitrit
> Subject: Re: [U-Boot] [PATCH v10] Marvell MV88F6281GTW_GE 
> Board support
> 
> Dear Prafulla Wadaskar,
> 
> In message 
> <1242865967-7179-1-git-send-email-prafulla at marvell.com> you wrote:
> > 
> > This is Marvell's 88F6281_A0 based custom board developed 
> for wireless 
> > access point product
> 
> > --- /dev/null
> > +++ b/board/Marvell/mv88f6281gtw_ge/Makefile
> > @@ -0,0 +1,51 @@
> > +#
> > +# (C) Copyright 2009
> > +# Marvell Semiconductor <www.marvell.com> # Prafulla Wadaskar 
> > +<prafulla at marvell.com>
> 
> As mentioned before, this makes no sense. Either Marvell 
> holds the copyright, or you do.
Marvell holds copyright, I will remove "prafulla at marvell.com"
This is there from first submission in all the patches
such comments in early feedback is more helpful....
I will correct and re-submit all patches...

> > +#define CONFIG_KIRKWOOD_RGMII_PAD_1V8	/* Set RGMII 
> Pad voltage to 1.8V */
> 
> Line too long.
BTW what is max allowed line size? All line are below 80 chars.

Regards..
Prafulla . .