[U-Boot] [PATCH v10] Marvell MV88F6281GTW_GE Board support

Wolfgang Denk wd at denx.de
Fri May 22 17:21:19 CEST 2009


Dear Prafulla Wadaskar,

In message <73173D32E9439E4ABB5151606C3E19E201CF9E687F at SC-VEXCH1.marvell.com> you wrote:
> 
> > As mentioned before, this makes no sense. Either Marvell 
> > holds the copyright, or you do.
> Marvell holds copyright, I will remove "prafulla at marvell.com"
> This is there from first submission in all the patches
> such comments in early feedback is more helpful....

Yes, I am aware of this - sorry. You know how this works - you submit
something, and the second after you hit the "send"  botton  you  will
see  a blatant typo. Same here - I've scanned several versions of the
files and did not realize this, but not it hit me.

> I will correct and re-submit all patches...

Thanks.

> > > +#define CONFIG_KIRKWOOD_RGMII_PAD_1V8	/* Set RGMII 
> > Pad voltage to 1.8V */
> > 
> > Line too long.
> BTW what is max allowed line size? All line are below 80 chars.

The maximum line is 80 characters. Please keep in mind that one TAB
character may occupy several columns - I guess you measured the
character count, and not the line length.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Use C++ to confuse your enemies; use C to produce stable code.


More information about the U-Boot mailing list