[U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile
Wolfgang Denk
wd at denx.de
Sun May 24 19:13:31 CEST 2009
Dear Jean-Christophe PLAGNIOL-VILLARD,
In message <20090524151849.GJ26561 at game.jcrosoft.org> you wrote:
> On 00:28 Sun 24 May , Wolfgang Denk wrote:
> > Dear Jean-Christophe PLAGNIOL-VILLARD,
> >
> > In message <1243107758-4528-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> > > at the first run of make we generate the autoconf.mk and autoconf.mk.dep
> > > if not already the case and we currently include only to .dep
> > >
> > > in order to use these autogenerated value we need to include it also evenif
> > > it's include in config.mk but it's done before there generation
> > >
> > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> >
> > Can you please explain which exact problem you are fixing here? I. e.
> in order to use these autogenerated value we need to include it also evenif
> it's include in config.mk but it's done before there generation
Believe me, I can read.
Just repeating the same words you already used in the commit message
is not helpful at all. Actually it I cannot help but consider this
affronting.
I did not understand the words there, and I don't understand them
here.
> which we need to do this
>
> ifdef CONFIG_CPU_LITTLE_ENDIAN
> .....
> else
> ....
> endif
We need to do this. And am I now supposed to guess where (i. e. in
which spoecific file) we might need to do this or why and why it may
or may not be working? Come on. This is not an explanation. This is
just throwing words without any meaning at me.
I'm not willing to discuss on such a base.
Please try to explain in a understandable way what you mean (and than
use this understandable explanation for the commit message).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A person who is more than casually interested in computers should be
well schooled in machine language, since it is a fundamental part of
a computer. -- Donald Knuth
More information about the U-Boot
mailing list