[U-Boot] [PATCH v10] Marvell MV88F6281GTW_GE Board support

[Prafulla Wadaskar]

> > + */
> > +
> > +#include <common.h>
> > +#include <netdev.h>
> > +#include <asm/arch/kirkwood.h>
> > +#include <asm/arch/mpp.h>
> > +#include "mv88f6281gtw_ge.h"
> please move the mv88f6281gtw_ge.h
> to include/asm-arm/arch-kirkwood/
Sure... I will do it :-)

> > +int board_init(void)
> > +{
> > +	/*
> > +	 * default gpio configuration
> > +	 * There are maximum 64 gpios controlled through 2 sets 
> of registers
> > +	 * the  below configuration configures mainly initial LED status
> > +	 */
> > +	kw_config_gpio(MV88F6281GTW_GE_OE_VAL_LOW,
> > +			MV88F6281GTW_GE_OE_VAL_HIGH,
> > +			MV88F6281GTW_GE_OE_LOW, 
> MV88F6281GTW_GE_OE_HIGH);
> > +
> > +	/* Multi-Purpose Pins Functionality configuration */
> > +	u32 kwmpp_config[] = {
> do you really need to configure all of this IO?
Yes
I device needs all IO initializations done to make sure unused MPPs must be configured to GPIOs.
This is required to reduce overall boards noise that we have identified through h/w test in the lab
 
> > +		MPP0_SPI_SCn,
> > +		MPP1_SPI_MOSI,
> > +		MPP2_SPI_SCK,
> > +		MPP3_SPI_MISO,
> please add a device init api as done for davinci or at91 
> (could be done in an other patch)
I could not get any reference for davinci or at91 for "device_init" 
Can you please provide me a specific pointer ?

OR do you mean to create new api "device_init" to do soc/device specific init ?
I think this is really not required here since it is specific to kirkwood implementation and may not apply for other architectures.

In my opinion we do not need any specific init here in this code... Pls clarify...

Regards..
Prafulla . .