[U-Boot] [PATCH v2] Gbe Controller driver support for kirkwood SOCs

[Prafulla Wadaskar]

Hi Ben,

How are you?
Seems to be very busy as usual.... :-)

Can you pls kindly take out some time to review these patches.
hopefully they are as per your requirements since we have invested considerable time to make them up to the mark.
May be-you can accept them :-) 
http://lists.denx.de/pipermail/u-boot/2009-May/053111.html
http://lists.denx.de/pipermail/u-boot/2009-May/052905.html
Just to share with you,
in netdev.h- though struct and enums defined looks similar-
I have used separate struct and enums for both mv88e61xx and mv88e1116 because only basic init support is available in those drives, but in coming time there will be more features added to them.
I think since these are initial drivers in net/phy/ we should provide common/phy.h and keep netdev.h untouched
What do you think?

Also you might be ready with review comments for this
http://lists.denx.de/pipermail/u-boot/2009-May/053113.html
Nothing much changed in v4 compared to patch version v1.
few global comments that I received for this patch from you are-
1. the code is too big.
2. can you strip down features to minimum
Just to reply these: 
the entire egiga driver is kept as separate driver .c and .h,
I am in progress to reuse the code from other drivers.
The features are kept minimal required but I can cut down some of features like "update network statistics" so as to make code size small and acceptable :-)
Still your comments will help me to provide better code...

Last but not least
Shall I resend above patches if you feel this is more comfortable for you?
 
Regards..
Prafulla. . .  

> -----Original Message-----
> From: Ben Warren [mailto:biggerbadderben at gmail.com] 
> Sent: Tuesday, May 12, 2009 12:38 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; 
> Ronen Shitrit
> Subject: Re: [U-Boot] [PATCH v2] Gbe Controller driver 
> support for kirkwood SOCs
> 
> Hi Prafulla,
> 
> Prafulla Wadaskar wrote:
> > Hi All
> >
> > Ping....
> > I didn't here any feedback from anyone, waiting for your valued 
> > comments :-(
> >
> >   
> I've started reviewing this driver - it's a lot to digest 
> (2500 lines!?!).  Please think a little about what features 
> are really needed here.  For example, do you really need RMON 
> in a bootloader?  I'll try to provide more specific feedback soon.
> > Regards..
> > Prafulla . . 
> >
> >   
> regards,
> Ben
>