[U-Boot] [PATCH] at91: Add support for MEESC board of esd gmbh

[Jean-Christophe PLAGNIOL-VILLARD]

On 08:21 Mon 25 May     , Daniel Gorsulowski wrote:
> Jean-Christophe PLAGNIOL-VILLARD schrieb:
> >> +
> >> +static void meesc_ethercat_hw_init(void)
> >> +{
> >> +	/* Configure SMC EBI1_CS0 for EtherCAT */
> >> +	at91_sys_write(AT91_SMC1_SETUP(0),
> >> +		AT91_SMC_NWESETUP_(0) | AT91_SMC_NCS_WRSETUP_(0) |
> >> +		AT91_SMC_NRDSETUP_(0) | AT91_SMC_NCS_RDSETUP_(0));
> >> +	at91_sys_write(AT91_SMC1_PULSE(0),
> >> +		AT91_SMC_NWEPULSE_(4) | AT91_SMC_NCS_WRPULSE_(9) |
> >> +		AT91_SMC_NRDPULSE_(4) | AT91_SMC_NCS_RDPULSE_(9));
> >> +	at91_sys_write(AT91_SMC1_CYCLE(0),
> >> +		AT91_SMC_NWECYCLE_(10) | AT91_SMC_NRDCYCLE_(5));
> >> +	/* Configure behavior at external wait signal, byte-select mode, 16 bit
> >> +	data bus width, none data float wait states and TDF optimization */
> >> +	at91_sys_write(AT91_SMC1_MODE(0),
> >> +		AT91_SMC_READMODE | AT91_SMC_EXNWMODE_READY |
> >> +		AT91_SMC_BAT_SELECT | AT91_SMC_DBW_16 | AT91_SMC_TDF_(0) |
> >> +		AT91_SMC_TDFMODE);
> >> +
> >> +	/* Configure RDY/BSY */
> >> +	at91_set_B_periph(AT91_PIN_PE20, 0);	/* EBI1_NWAIT */
> > do you really need this
> > you do not seems to use it anywhere?
> Yes, I really need this for debugging the ET1100 and for accessing its process
> memory by md/mw/mm.
ok maybe a note in a README will be nice
> >> +}
> >> +
> >> +#ifdef CONFIG_HAS_DATAFLASH
> >> +#ifdef MACH_TYPE_MEESC	/* while asm-arm/mach-types.h is not up to date */
> > you need to send a sync request
> As I recognized, you sync against latest kernel source?
> The problem is, the mach-types in kernel source is not up to date:
> 	# Last update: Mon Mar 23 20:09:01 2009
> There has been several sync requests since my commit on Tue, 7 Apr 2009 11:19:31 GMT
> (see http://www.arm.linux.org.uk/developer/machines/list.php?id=2165), but my board
> is not included in kernel source yet. So, imho a sync request makes no sense. Unless
> you sync against http://www.arm.linux.org.uk/developer/machines/download.php
Yes If need I'll sync against the last DB

Just add a note in the --- section of your patch to remind me that your board
need it I'll do it just before applied it

Best Regards,
J.