[U-Boot] [PATCH v4] Gbe Controller driver support for kirkwood SOCs

[Prafulla Wadaskar]

Hi Ben

Thanks...
> > diff --git a/cpu/arm926ejs/kirkwood/cpu.c 
> > b/cpu/arm926ejs/kirkwood/cpu.c index 1286cac..d37c2e2 100644
> > --- a/cpu/arm926ejs/kirkwood/cpu.c
> > +++ b/cpu/arm926ejs/kirkwood/cpu.c
> > @@ -314,3 +314,11 @@ int arch_misc_init(void)
> >  	return 0;
> >  }
> >  #endif /* CONFIG_ARCH_MISC_INIT */
> > +
> > +#ifdef CONFIG_KIRKWOOD_EGIGA
> > +int cpu_eth_init(bd_t *bis)
> > +{
> > +	kirkwood_egiga_initialize(bis);
> > +	return 0;
> > +}
> > +#endif
> >   
> Please move this part (cpu.c) to a different patch.  This one 
> should only include the driver itself, and I can't apply it 
> since the cpu.c file doesn't exist yet...
Cool..I will provide separate Kirwood SOC Support patch for this

> 
> I don't have any technical problems with this patch, but 
> please consider the following:
> 
> 1. Statistics are great to have, but most people won't look 
> at them and all the associated logic makes the driver very 
As I said earlier I am removing this stuff, this will make code smaller
> big.  Please conditionally compile that stuff in.
Probably in latter phase I will submit a patch to support statistics
 
> 
> 2. Please ensure that all lines are <= 78 characters long (80 
> minus the initial character that diff puts in)
Yes. this was a problem with Wolfgang(I think) some lines in the code are 79/80 chars long
I will correct them.

Regards..
Prafulla . .