[U-Boot] [PATCH v10] Marvell Kirkwood family SOC support NAND discussion

[Stefan Roese]

On Tuesday 26 May 2009 10:48:08 Prafulla Wadaskar wrote:
> > I know that NAND support is generally available in U-Boot.
> > But what's currently missing is the platform/board specific
> > driver for Kirkwood. Seems that you included the Kirkwood
> > NAND driver into your Sheevaplug support patch.
> > Good. But this driver should be placed in drivers/mtd/nand so
> > that other Kirkwood boards can use it as well.
>
> Good Feedback...
> The name board_nand_init() is confusing here.... Why the board specific
> code is in drivers/mtd/nand/?

Perhaps somewhat historic reasons....

> Whereas I can see more references in board/*

Yes, this needs more cleanup/moving of those drivers into this common place.

> But looking other code references in this folder your feedback stands valid
> BTW: the arch_nand_init() or device_nand_init() is the right name
> here...Scott need to suggest on this since it involves rework on other
> drivers too.

You should use board_nand_init() for now. We could move to another name in the 
future.

> Meanwhile for my next patch update I will move nand.c from sheevaplug to
> drivers/mtd/nand/kirkwood_nand.c

Great. Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================