[U-Boot] [PATCH][u-boot arm/next] ARM DaVinci DM365 Support

[Paulraj, Sandeep]

Jean-Christophe,
               please see inline 

> -----Original Message-----
> From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com] 
> Sent: Friday, May 22, 2009 8:12 PM
> To: Paulraj, Sandeep
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH][u-boot arm/next] ARM DaVinci 
> DM365 Support
> 
> > +
> > +#ifdef CONFIG_NAND_DAVINCI
> > +
> > +static void nand_dm365evm_select_chip(struct mtd_info 
> *mtd, int chip)
> > +{
> > +	struct nand_chip	*this = mtd->priv;
> > +	u32			wbase = (u32) this->IO_ADDR_W;
> > +	u32			rbase = (u32) this->IO_ADDR_R;
> > +
> > +	if (chip == 1) {
> > +		__set_bit(14, &wbase);
> > +		__set_bit(14, &rbase);
> > +	} else {
> > +		__clear_bit(14, &wbase);
> > +		__clear_bit(14, &rbase);
> > +	}
> > +	this->IO_ADDR_W = (void *)wbase;
> > +	this->IO_ADDR_R = (void *)rbase;
> > +}
> the 355 use the same it
> did all davinci will use the same?
No All DaVinci's will not use the same.
Leopard which based on DM355 will not use this
> > +
> > +int board_nand_init(struct nand_chip *nand)
> > +{
> > +	davinci_nand_init(nand);
> > +	nand->select_chip = nand_dm365evm_select_chip;
> > +	return 0;
> > +}
> > +
> > +#endif
> > diff --git a/cpu/arm926ejs/davinci/Makefile 
> b/cpu/arm926ejs/davinci/Makefile
> > index 6eaa89c..c20e0e2 100644
> > --- a/cpu/arm926ejs/davinci/Makefile
> > +++ b/cpu/arm926ejs/davinci/Makefile
> > @@ -29,6 +29,7 @@ LIB	= $(obj)lib$(SOC).a
> >  
> >  COBJS-y				+= cpu.o timer.o psc.o
> >  COBJS-$(CONFIG_SOC_DM355)	+= dm355.o
> > +COBJS-$(CONFIG_SOC_DM365)	+= dm365.o
> >  COBJS-$(CONFIG_SOC_DM644X)	+= dm644x.o
> >  COBJS-$(CONFIG_DRIVER_TI_EMAC)	+= ether.o lxt972.o dp83848.o
> >  
> > diff --git a/cpu/arm926ejs/davinci/dm365.c 
> b/cpu/arm926ejs/davinci/dm365.c
> > new file mode 100644
> > index 0000000..4e64c29
> > --- /dev/null
> > +++ b/cpu/arm926ejs/davinci/dm365.c
> please do this in an other patch
Will do.
Again this depends on whether my earlier patch is added to the tree
I will need to include my new "devices.h" header file for this
> > @@ -0,0 +1,38 @@
> > +/*
> > + * SOC-specific code for TMS320DM365 and similar chips
> > + *
> > + * Copyright (C) 2009 Sandeep Paulraj
> > + *
> > + * See file CREDITS for list of people who contributed to this
> > + * project.
> > + *
> > + * This program is free software; you can redistribute it 
> and/or modify
> > + * it under the terms of the GNU General Public License as 
> published by
> > + * the Free Software Foundation; either version 2 of the 
> License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General 
> Public License
> > + * along with this program; if not, write to the Free Software
> > + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> > + */
> > +
> > +#include <common.h>
> > +#include <asm/arch/hardware.h>
> > +
> > +
> > +void davinci_enable_uart0(void)
> > +{
> > +	lpsc_on(DAVINCI_LPSC_UART0);
> > +}
> > +
> > +#ifdef CONFIG_DRIVER_DAVINCI_I2C
> > +void davinci_enable_i2c(void)
> > +{
> > +	lpsc_on(DAVINCI_LPSC_I2C);
> > +}
> > +#endif
> Best Regards,
> J.
> 
> 
Thanks,
Sandeep