[U-Boot] [PATCH 02/10] USB add macros for debugging usb device setup.
Tom
Tom.Rix at windriver.com
Sun Nov 1 03:00:09 CET 2009
Mike Frysinger wrote:
> On Saturday 31 October 2009 13:37:39 Tom Rix wrote:
>> +#ifdef DEBUG
>> +static inline void print_device_descriptor(struct usb_device_descriptor
>> *d) +{
>> + serial_printf("usb device descriptor \n");
>
> do you really need serial_printf() ? what's wrong with debug() ? then you
> dont even really need "#ifdef DEBUG" around all the functions ...
> -mike
The explicit serial_printf is done because this patch set changes the
stdin and stdout for serial to usbtty.
When you use printf to debug printf, you regress into a bad state.
Tom
More information about the U-Boot
mailing list