[U-Boot] [PATCH] Add I2C multibus support for OMAP2/3 boards

Tom Tom.Rix at windriver.com
Sun Nov 1 13:43:02 CET 2009


Dirk Behme wrote:
> Tom Rix wrote:
>> From: Syed Mohammed Khasim <khasim at ti.com>
>>
>> This was cherry-picked from
>>
>> repo: http://www.beagleboard.org/u-boot-arm.git
>> commit: 52eddcd07c2e7ad61d15bab2cf2d0d21466eaca2
>>
>> In addition to adding multibus support, this patch
>> also cleans up the register access.  The register
>> access has been changed from #defines to a structure.
> 
> Have you looked at my proposal I sent some hours before your patch?

Sorry.  I did not.
Not surprisingly it looks similar.

The formatting changes you mentioned were part of the original
cherry-picked commit.  I tried to leave as much of the original
commit intact as possible.  I ran but ignored the output of
checkpatch.. The biggest complaint it has is with 80 char lines.

I looked over your patch.
It looks like an improvement to mine.

I'm all for dropping mine and using yours.
I will run test yours.

Do you have a zippy board that you can use to test the 2nd bus ?

Tom


More information about the U-Boot mailing list