[U-Boot] Best way of making some drivers common across kirkwood and orion5x SoCs?

[Prafulla Wadaskar]

Hi Albert 

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de 
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Albert ARIBAUD
> Sent: Saturday, October 31, 2009 8:42 PM
> To: u-boot at lists.denx.de
> Subject: Re: [U-Boot] Best way of making some drivers common 
> across kirkwood and orion5x SoCs?
> 
> Wolfgang Denk a écrit :
> 
>  > "soc.h" is eventually a too generic name.
> 
> I'd actually chosen it "as generic as" the 'cpu.h' file which already 
> exists in the kirkwood arch (and others), but making it more 
> specific is 
> ok, as long as it is not as specific as 'kirkwood' -- see 
> below for an 
> alternate proposal.

Anything inside "Kirkwood" folder is Kirkwood specific, that applies for cpu.c/h.
There is no sense to keep soc.h in SOC specific folders.
If we are keeping it in Arch specific folder then it is applicable for all other SOCs too.

> 
>  > Please don't use symlinks.
> 
> I've already started with replacing the file rather than 
> symlinking, so 
> that's fine with me.

I fully ack with NOT to use symlinks

> 
>  >> Would this approach be clean enough to be considered for 
> inclusion 
> in mainline?
>  >
>  > Yes, except for the "soc.h" name. And no links, please.
> 
> Would a name such as "marvell.h" be more acceptable? This would be 
> consistent with my intent to replace kirkwood references with marvell 
> ones in all non-kirkwood-specific symbols, e.g. 
> kikwood_egiga_initialize 
> would become marvell_egiga_initialize etc.

I disagree with this,
- marvell.h is again more generic name applicable for all other Marvell IPs that May not be the same on other SOCs unless we call them with specific names.
The name kirkwood_egiga.c/h clearly specifies it is for kirkwood.
If it can be used as it is, well there are no issues. 
We can tune it to address Orion issues if any so that kirkwood/orion can be supported though clean abstraction.
Otherwise I would always prefer to have separate driver (for ex. Orion_egiga.c/h).

Regards..
Prafulla . .

> 
> Amicalement,
> -- 
> Albert.
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>