[U-Boot] [PATCH] Enable port-mapped access to 16550 UART

[Detlev Zundel]

Hi Graeme,

>> we at least start using the Linux convention and turn all the register
>> accesses into "serial_{in,out}" and define these for X86 and !X86 like
>> you did.
>>
>> This way should be somewhat clearer than defining a "writeb" not to be a
>> writeb after all, which I find confusing.
>>
>> What do you think?
>>
>
> So essentially go with my patch but rename uart_writeb to serial_out and
> uart_readb to serial_in? If so, I'll re-spin

Yes please.

Thanks
  Detlev

-- 
The fact is, volatile on data structures is a bug. It's a wart in the C 
language. It shouldn't be used.
                                   -- Linus Torvalds 
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de