[U-Boot] [PATCH ARM] Move s3c24x0 header files to asm-arm/arch-s3c24x0/

Minkyu Kang promsoft at gmail.com
Wed Nov 4 07:01:01 CET 2009


Dear Kevin Morfitt,

2009/11/3 kevin.morfitt at fearnside-systems.co.uk
<kevin.morfitt at fearnside-systems.co.uk>:
> This patch moves the s3c24x0 header files from include/ to
> include/asm-arm/arch-s3c24x0/.
>
> checkpatch.pl showed 2 errors and 3 warnings. The 2 errors were both due
> to a non-UTF8 character in David M?ller's name:
>
> ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
> #489: FILE: include/asm-arm/arch-s3c24x0/s3c2410.h:3:
> + * David M?ller ELSOFT AG Switzerland. d.mueller at elsoft.ch
>
> As David's name correctly contains a non-UTF8 character I haven't fixed
> these errors.
>
> The 3 warnings were all because of the use of 'volatile' in s3c24x0.h:
>
> WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
> #673: FILE: include/asm-arm/arch-s3c24x0/s3c24x0.h:35:
> +typedef volatile u8    S3C24X0_REG8;
> +typedef volatile u16   S3C24X0_REG16;
> +typedef volatile u32   S3C24X0_REG32;
>
> I'll fix these errors in another patch.
>
> Tested by running MAKEALL for ARM8 targets and ensuring there were no new
> errors or warnings.
>
> Signed-off-by: Kevin Morfitt <kevin.morfitt at fearnside-systems.co.uk>
> ---
>  board/mpl/vcma9/vcma9.c                |    2 +-
>  board/mpl/vcma9/vcma9.h                |    2 +-
>  board/samsung/smdk2400/smdk2400.c      |    2 +-
>  board/samsung/smdk2410/smdk2410.c      |    2 +-
>  board/sbc2410x/sbc2410x.c              |    2 +-
>  board/trab/cmd_trab.c                  |    2 +-
>  board/trab/rs485.c                     |    2 +-
>  board/trab/rs485.h                     |    2 +-
>  board/trab/trab.c                      |    2 +-
>  board/trab/trab_fkt.c                  |    2 +-
>  board/trab/tsc2000.c                   |    2 +-
>  board/trab/vfd.c                       |    2 +-
>  cpu/arm920t/s3c24x0/interrupts.c       |    4 +-
>  cpu/arm920t/s3c24x0/speed.c            |    4 +-
>  cpu/arm920t/s3c24x0/timer.c            |    4 +-
>  cpu/arm920t/s3c24x0/usb.c              |    4 +-
>  cpu/arm920t/s3c24x0/usb_ohci.c         |    4 +-
>  drivers/i2c/s3c24x0_i2c.c              |    4 +-
>  drivers/mtd/nand/s3c2410_nand.c        |    2 +-
>  drivers/rtc/s3c24x0_rtc.c              |    4 +-
>  drivers/serial/serial_s3c24x0.c        |    4 +-
>  include/asm-arm/arch-s3c24x0/s3c2400.h |  136 +++++++
>  include/asm-arm/arch-s3c24x0/s3c2410.h |  146 +++++++
>  include/asm-arm/arch-s3c24x0/s3c24x0.h |  656 ++++++++++++++++++++++++++++++++
>  include/s3c2400.h                      |  136 -------
>  include/s3c2410.h                      |  146 -------
>  include/s3c24x0.h                      |  656 --------------------------------
>  27 files changed, 967 insertions(+), 967 deletions(-)
>  create mode 100644 include/asm-arm/arch-s3c24x0/s3c2400.h
>  create mode 100644 include/asm-arm/arch-s3c24x0/s3c2410.h
>  create mode 100644 include/asm-arm/arch-s3c24x0/s3c24x0.h
>  delete mode 100644 include/s3c2400.h
>  delete mode 100644 include/s3c2410.h
>  delete mode 100644 include/s3c24x0.h
>

applied to u-boot-samsung

Thanks
Minkyu Kang
-- 
from. prom.
www.promsoft.net


More information about the U-Boot mailing list