[U-Boot] [PATCH] fsl_pci_init_port end-point initialization is broken

Kumar Gala galak at kernel.crashing.org
Thu Nov 5 01:07:09 CET 2009


On Nov 2, 2009, at 9:05 AM, Ed Swarthout wrote:

> commit 70ed869e broke fsl pcie end-point initialization.
> Returning 0 is not correct.  The function must return the first free
> bus number for the next controller.
>
> fsl_pci_init() must still be called and a bus allocated even if the
> controller is an end-point.
>
> Signed-off-by: Ed Swarthout <Ed.Swarthout at freescale.com>
> ---
>
> This fixes the current breakage, but I don't think adding another
> layer (fsl_pci_init_port) and parameter structure is all that helpful.
>
> So now there is:
>
> pci_init_board() -> fsl_pci_init_port() -> fsl_pci_init() ->
> pciauto_setup_device()
>
> with even less flexibility on setting up the inbound
> and outbound windows.
>
> drivers/pci/fsl_pci_init.c |   19 +++++--------------
> 1 files changed, 5 insertions(+), 14 deletions(-)

applied w/update (reverted 70ed869e and used a standard way to  
determine PCI host vs agent/end-point.

- k


More information about the U-Boot mailing list