[U-Boot] [PATCH] Save environment data to mmc.

[Lv Terry-R65388]

 Hi Mike,

	I will fix the two issues you pointed. Thanks a lot.

	Actually, env_mmc.c is written based on env_nand.c in u-boot 1.3.3.

	I have modified it according to the latest changes in environment code. But seems there's still a lot of issue. Sorry for that.

	It works well in our project. So I want to add it to u-boot mainline.

	Thanks~~

Yours
Terry

-----Original Message-----
From: Mike Frysinger [mailto:vapier at gentoo.org] 
Sent: 2009年11月5日 20:10
To: u-boot at lists.denx.de
Cc: Lv Terry-R65388
Subject: Re: [U-Boot] [PATCH] Save environment data to mmc.

On Thursday 05 November 2009 02:43:33 Terry Lv wrote:
> --- a/common/Makefile
> +++ b/common/Makefile
> @@ -58,6 +58,7 @@ COBJS-$(CONFIG_ENV_IS_IN_NAND) += env_nand.o
>  COBJS-$(CONFIG_ENV_IS_IN_NVRAM) += env_nvram.o
>  COBJS-$(CONFIG_ENV_IS_IN_ONENAND) += env_onenand.o
>  COBJS-$(CONFIG_ENV_IS_IN_SPI_FLASH) += env_sf.o
> +COBJS-$(CONFIG_ENV_IS_IN_MMC) += env_mmc.o

this list is attempting to stay in order according to the CONFIG name, so you should add this above the NAND ENV entry

> --- /dev/null
> +++ b/common/env_mmc.c
> @@ -0,0 +1,359 @@
> +#if defined(CONFIG_ENV_IS_IN_MMC) /* Environment is in MMC Flash */

you dont need this line anymore as it's in the Makefile

> +#ifdef CONFIG_INFERNO
> +#error CONFIG_INFERNO not supported yet #endif

is this really needed ?

> +extern int default_environment_size;

this looks like another useless line copy & pasted from whatever file you based this on -mike