[U-Boot] [PATCH] Fix build failure in examples/standalone
Wolfgang Denk
wd at denx.de
Sun Nov 8 23:27:25 CET 2009
Dear Mike Frysinger,
In message <200911061122.16814.vapier at gentoo.org> you wrote:
>
> > Just after pressing this "ENTER", I tried the following:
> > [Moved $(ELF-y) to end of the assignment and kill trailing spaces]
> >
> > -ELF := $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU))
> > +ELF := $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU)) $(ELF-y)
> >
> > And it worked! The message for COBJS shows:
> >
> > Makefile:47: *** *** COBJS evaluates to [ hello_world.o
> > smc911x_eeprom.o]. Stop.
> >
> > So, maybe "make v3.80" has problems with trailing spaces.
> >
> > For the fix, I can resubmit with the change shown above OR we could
> > keep the original. Let me know your thoughts.
>
> i kind of prefer this method. if we go with the first method, it needs to>
> have a comment there explaining why the strip exists:
> # we need the strip to workaround a bug in make-3.80 and whitespace/:=
We definitely need an explanationin any case - otherwise someone might
come up with a patch to change the order again (say, to come up with a
common form) and it breaks again.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I believe the use of noise to make music will increase until we
reach a music produced through the aid of electrical instruments
which will make available for musical purposes any and all sounds
that can be heard." - composer John Cage, 1937
More information about the U-Boot
mailing list