[U-Boot] [PATCH] omap3: add CM-T35 board

[Mike Rapoport]

Peter Tyser wrote:
> On Wed, 2009-11-11 at 15:41 +0200, Mike Rapoport wrote:
>> Paulraj, Sandeep wrote:
>>>> -----Original Message-----
>>>> From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de]
>>>> On Behalf Of Mike Rapoport
>>>> Sent: Wednesday, November 11, 2009 3:03 AM
>>>> To: u-boot at lists.denx.de
>>>> Cc: Mike Rapoport
>>>> Subject: [U-Boot] [PATCH] omap3: add CM-T35 board
>>>>
>>>> Add CM-T35 board support
>>>>
>>>> Signed-off-by: Mike Rapoport <mike at compulab.co.il>
>>>> ---
>>>>  Makefile                       |    3 +
>>>>  board/cm-t35/Makefile          |   47 ++++++
>>>>  board/cm-t35/cm-t35.c          |  196 ++++++++++++++++++++++++++
>>>>  board/cm-t35/cm-t35.h          |  173 +++++++++++++++++++++++
>>>>  board/cm-t35/config.mk         |   30 ++++
>>>>  include/configs/omap3_cm-t35.h |  301
>>> If you look at the way OMAP3 is structured now.
>>> Board specific stuff goes into /board/ti/
>>>
>>> It has beagle, sdp, etc
>> As far as I know, U-Boot structures board files by board/vendor/board rather
>> than board/cpu-vendor/board. That's why I've put cm-t35 directly under board/,
>> just like overo.
> 
> Agreed.  You should use board/$vendor/$board if $vendor plans on having
> more than 1 board, and board/$board is OK if you're only supporting this
> one board.
> 
> <snip>
> 
>>>> --- a/Makefile
>>>> +++ b/Makefile
>>>> @@ -3168,6 +3168,9 @@ omap3_zoom1_config :    unconfig
>>>>  omap3_zoom2_config : unconfig
>>>>       @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 zoom2 logicpd omap3
>>>>
>>>> +omap3_cm-t35_config :        unconfig
>>>> +     @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 cm-t35 NULL omap3
>>>> +
> 
> I'd title your _config rule the same as your board name, ie drop the
> omap3_ prefix above.  And the above list should be alphabetically
> sorted.

I'd prefer to keep the 'omap3_' prefix to stay inline with other omap3 boards.

> Best,
> Peter
> 
> 

-- 
Sincerely yours,
Mike.