[U-Boot] [PATCH] omap3: add CM-T35 board

Mike Rapoport mike at compulab.co.il
Wed Nov 11 15:56:13 CET 2009



Tom wrote:
> Peter Tyser wrote:
>> <snip>
>>
>>>>>>> --- a/Makefile
>>>>>>> +++ b/Makefile
>>>>>>> @@ -3168,6 +3168,9 @@ omap3_zoom1_config :    unconfig
>>>>>>>  omap3_zoom2_config : unconfig
>>>>>>>       @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 zoom2 logicpd
>>>>>>> omap3
>>>>>>>
>>>>>>> +omap3_cm-t35_config :        unconfig
>>>>>>> +     @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 cm-t35 NULL omap3
>>>>>>> +
>>>> I'd title your _config rule the same as your board name, ie drop the
>>>> omap3_ prefix above.  And the above list should be alphabetically
>>>> sorted.
>>> I'd prefer to keep the 'omap3_' prefix to stay inline with other
>>> omap3 boards.
>>
>> Just because the other omap3_ board are wrong doesn't mean your board
>> should be too:)  This same question was discussed for the devkit8000:
>> http://www.mail-archive.com/u-boot@lists.denx.de/msg21317.html
>>
> 
> Please drop the omap3_ prefix.
> New boards are following the standard convention.

Ok

> Tom
> 
> 

-- 
Sincerely yours,
Mike.



More information about the U-Boot mailing list