[U-Boot] [PATCH 1/3] DA830: Add pinmux for USB0_DRVVBUS

Tom Tom.Rix at windriver.com
Thu Nov 12 17:10:16 CET 2009


Paulraj, Sandeep wrote:
> 
>> Ajay Kumar Gupta wrote:
>>> USB0_DRVVBUS pinmux configuration is required for USB functinality
>>> in uboot.
>>>
>>> Signed-off-by: Ajay Kumar Gupta <ajay.gupta at ti.com>
>>> Signed-off-by: Swaminathan S <swami.iyer at ti.com>
>>> ---
>>> This patch set is created against Nick Thompson's latest patch set
>>> (v5) on DA8xx support and another patch from him on Davinci pinmux.
>>> [Davinci: add a pin multiplexer configuration API]
>> It is difficult to review code that is dependent on other outstanding
>> patches.
>>
>> The base DA8xx support will be in arm-ti branch shortly.
>> Please rebase these patches when this happens and resubmit.
>>
>> Tom
> 
> I think he might have added it locally and then made his patches.
> So he might not have to rebase.
> 
> Without Nick's patches da830evm.c would not even exist :-)
> 
> 

My issue is not with how development continues, it is with how patches
are reviewed.  To really review this patchset someone would need to
apply the pin mux patch, the the 8xx patch set, then this set.
Reviewing patches against outstanding patches does not scale and should be
avoided.

Tom





More information about the U-Boot mailing list