[U-Boot] [PATCH v4] OMAP3: add CM-T35 board

[Mike Rapoport]

Tom wrote:
> Mike Rapoport wrote:
>> Tom,
>>
>> Tom wrote:
>>> Paulraj, Sandeep wrote:
>>>>> Add CM-T35 board support
>>>>>
>>> Please add more description of the board.
>>>
>>>>> Signed-off-by: Mike Rapoport <mike at compulab.co.il>
>>>>>
>>>>> -- 
>>>>> v2 changes:
>>>>> - rename board config file from omap3_cm-t35.h to cm-t35.h
>>>>> - remove SZ_xx references
>>>>> - add MAKEALL/MAINTEINERS entries
>>>
>>> Wolfgang had made this comment on V2 that has not been addressed.
>>>
>>>>  > diff --git a/include/configs/cm-t35.h b/include/configs/cm-t35.h
>>>>> new file mode 100755
>>>>>> index 0000000..b881112
>>>>>> --- /dev/null
>>>>>> +++ b/include/configs/cm-t35.h
>>>> ...
>>>>>> +#ifndef __ASSEMBLY__
>>>>>> +extern struct gpmc *gpmc_cfg;
>>>>>> +extern unsigned int boot_flash_base;
>>>>>> +extern volatile unsigned int boot_flash_env_addr;
>>>>>> +extern unsigned int boot_flash_off;
>>>>>> +extern unsigned int boot_flash_sec;
>>>>>> +extern unsigned int boot_flash_type;
>>>>>> +#endif
>>>> These should not be needed in your board config file. Please move to a
>>>> more appropriate header.
>>
>> As I've already answered Wolfgang ([1]), this is what _all_ other
>> omap3 board
>> do... Moving these requires rework of common omap3 code and updates to
>> all omap3
>> boards.
>>
>>
> 
> Yes this change would apply to all the omap3 boards.
> But it looks like they are are all the same change.
> 
> The change per board, would be to delete these externs once the
> first code change is made.
> 
> Since this is a code movement change, it can be verified by running
> MAKEALL arm before and after the change.

The problem here, that just moving these externs to e.g.
include/arm-arm/arch-omap3/mem.h is not enough. All omap3 boards set environment
related defines to these externs, and therefore without them common/env_nand
does not build. It seems that all the board_flash_* variables can be completely
removed completely, but I really don't know what was the original author
intention about those variables.

> Tom
> 
> 

-- 
Sincerely yours,
Mike.