[U-Boot] [PATCH v2] Fix build failure in examples/standalone

[Premi, Sanjeev]

> -----Original Message-----
> From: Premi, Sanjeev 
> Sent: Monday, November 09, 2009 10:43 PM
> To: u-boot at lists.denx.de
> Cc: Premi, Sanjeev
> Subject: [PATCH v2] Fix build failure in examples/standalone
> 
> Some versions of 'make' do not handle trailing white-spaces
> properly. Trailing spaces in ELF causes a 'fake' source to
> be added to the variable COBJS; leading to build failure
> (listed below). The problem was found with GNU Make 3.80.
> 
> Using text-function 'strip' as a workaround for the problem.
> 
> make[1]: Entering directory `/home/sanjeev/u-boot/examples/standalone'
> arm-none-linux-gnueabi-gcc -g  -Os   -fno-common -ffixed-r8 
> -msoft-float
> -D__KERNEL__ -DTEXT_BASE=0x80e80000 -I/home/sanjeev/u-boot/include
> -fno-builtin -ffreestanding -nostdinc -isystem 
> /opt/codesourcery/2009q1-
> 203/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/include -pipe 
>  -DCONFIG_
> ARM -D__ARM__ -marm  -mabi=aapcs-linux -mno-thumb-interwork 
> -march=armv5
> -Wall -Wstrict-prototypes -fno-stack-protector -g  -Os   
> -fno-common -ff
> ixed-r8 -msoft-float   -D__KERNEL__ -DTEXT_BASE=0x80e80000 
> -I/home/sanje
> ev/u-boot/include -fno-builtin -ffreestanding -nostdinc 
> -isystem /opt/co
> desourcery/2009q1-203/bin/../lib/gcc/arm-none-linux-gnueabi/4.
> 3.3/includ
> e -pipe  -DCONFIG_ARM -D__ARM__ -marm  -mabi=aapcs-linux 
> -mno-thumb-inte
> rwork -march=armv5 -I.. -Bstatic -T u-boot.lds  -Ttext 
> 0x80e80000 -o .c
> arm-none-linux-gnueabi-gcc: no input files
> make[1]: *** [.c] Error 1
> make[1]: Leaving directory `/home/sanjeev/u-boot/examples/standalone'
> make: *** [examples/standalone] Error 2
> premi #
> 
> Signed-off-by: Sanjeev Premi <premi at ti.com>
> ---
>  examples/standalone/Makefile |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/examples/standalone/Makefile 
> b/examples/standalone/Makefile
> index 5e2f2bc..c02ce43 100644
> --- a/examples/standalone/Makefile
> +++ b/examples/standalone/Makefile
> @@ -38,7 +38,13 @@ ELF-mpc8260                      += 
> mem_to_mem_idma2intr
>  ELF-ppc                          += sched
>  ELF-oxc                          += eepro100_eeprom
>  
> -ELF := $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU))
> +#
> +# Some versions of make do not handle trailing white spaces properly;
> +# leading to build failures. The problem was found with GNU 
> Make 3.80.
> +# Using 'strip' as a workaround for the problem.
> +#
> +ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU)))
> +
>  SREC = $(addsuffix .srec,$(ELF))
>  BIN  = $(addsuffix .bin,$(ELF))
>  
> -- 
> 1.6.2.2
> 
> 

Hi,

Just wanted to check if this update is okay?

Best regards,
Sanjeev