[U-Boot] [PATCH] crc32: Make crc32 build on non Linux too

Joakim Tjernlund joakim.tjernlund at transmode.se
Wed Nov 18 11:34:03 CET 2009


Wolfgang Denk <wd at denx.de> wrote on 17/11/2009 22:06:02:
>
> Dear Joakim Tjernlund,
>
> In message <1258446374-2919-1-git-send-email-Joakim.Tjernlund at transmode.se> you wrote:
> > The #include <asm/byteorder.h> is Linux specific. Use
> > compiler.h and adjust the code to cope.
> >
> > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund at transmode.se>
> > ---
> >
> >  Mike, how does this work for you?
>
> Could you please do me a favour and mark your patches in some way so
> everybody knows what these are?

This was a "reply" for Mikes comment on
[PATCH v2] crc32: Impl. linux optimized crc32()
Would it been better for you if I just included the patch
in a normal email reply?

>
> Is this for inclusion into mainline (I guess not) or intended for
> testing - you should use something like "[PATCH RFC]" in the Subject
> then.

I think the crc32 patch(es) are ready to go in after the pending release.

>
> Also, when reposting new versions of this stuff then please mark the
> version in the Subject (like '[PATCH RFC v5]"), and provide a history
> of changes between the versions below the "---" line.
>
> And PLEASE keep the In-reply-to: and References: headers so threading
> of the messages works.

Since this was a new email sent with git, I don't In-reply-to: and References:
should be there?

Anyhow, I can send a V3 version with everything in it to sum it up?

    Jocke



More information about the U-Boot mailing list