[U-Boot] [PATCH] OMAP3EVM: Added NAND support

[Scott Wood]

Nishanth Menon wrote:
>> +
>> +#define WRITE_NAND_COMMAND(d, adr)\
>> +                       writel(d, &nand_cs_base->nand_cmd)
> writel? i thought u had 16 bit nand device.
> 
>> +#define WRITE_NAND_ADDRESS(d, adr)\
>> +                       writel(d, &nand_cs_base->nand_adr)
>> +#define WRITE_NAND(d, adr) writew(d, &nand_cs_base->nand_dat)
>> +#define READ_NAND(adr) readl(&nand_cs_base->nand_dat)
> readl?? should'nt you be using readw?
> 
> Why these functions? does'nt mtd layer handle this? look at beagle ->
> it does not use that..
> 
>> +
>> +/* Other NAND Access APIs */
>> +#define NAND_WP_OFF() do {readl(&gpmc_cfg_base->config) |= GPMC_CONFIG_WP; } \
>> +                       while (0)
>> +#define NAND_WP_ON() do {readl(&gpmc_cfg_base->config) &= ~GPMC_CONFIG_WP; } \
>> +                       while (0)
>> +#define NAND_DISABLE_CE(nand)
>> +#define NAND_ENABLE_CE(nand)
>> +#define NAND_WAIT_READY(nand)  udelay(10)
>> +
> are these really needed?

No, they're not needed.  That is the legacy NAND interface that has been 
superseded and removed.

-Scott