[U-Boot] [PATCH v3] crc32: Impl. linux optimized crc32()

[Thiago A. Corrêa]

Hi,

On Thu, Nov 19, 2009 at 10:44 AM, Joakim Tjernlund
<Joakim.Tjernlund at transmode.se> wrote:
>
> +#define tole(x) cpu_to_le32(x)
> +

This define is only used once and at the constants table, after that,
cpu_to_le32 is called directly. Perhaps this could be removed and
cpu_to_le32 used instead, or change everything at that file to tole().
Two "symbols" to do the same thing doesn't seem right.

Personally I think cpu_to_le32 is more readable, at the expense of a
few more keyboard strokes.

Just my 2c :)

Resubmiting is a lot of trouble (at least to a git newbie like me), so
I think it could be a second patch to fix that anyway, assuming you
decide it's broken.

Kind Regards,
    Thiago A. Correa