[U-Boot] [PATCH] BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.

Måns Rullgård mans at mansr.com
Fri Nov 20 03:13:02 CET 2009


"Robert P. J. Day" <rpjday at crashcourse.ca> writes:

> Make it clear to a reader that the user of OMAP34XX macros in the
> (OMAP 3530-based) beagle config file is just fine.
>
> Signed-off-by: Robert P. J. Day <rpjday at crashcourse.ca>
>
> ---
>
>   i'll let dirk be the judge as to whether this is worth adding, or if
> he'd prefer a different phrasing.
>
> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> index 19a5ec9..9a03587 100644
> --- a/include/configs/omap3_beagle.h
> +++ b/include/configs/omap3_beagle.h
> @@ -30,6 +30,9 @@
>
>  /*
>   * High Level Configuration Options
> + *
> + * Note that, although the BeagleBoard incorporates an OMAP 3530,
> + * it's currently still valid to use OMAP34XX preprocessor values.
>   */
>  #define CONFIG_ARMCORTEXA8	1	/* This is an ARM V7 CPU core */
>  #define CONFIG_OMAP		1	/* in a TI OMAP core */

Since 34xx and 35xx are in fact exactly the same silicon, saying it is
"currently" valid seems a bit odd.  This sort of implies a planned
change.

-- 
Måns Rullgård
mans at mansr.com



More information about the U-Boot mailing list