[U-Boot] [PATCH 6/8] nhk8815: added keypad

[Wolfgang Denk]

Dear Alessandro Rubini,

In message <5a9bb8fb15cdb47d2ccd77af62f759ed493de944.1255086085.git.rubini@ unipv.it> you wrote:
> From: Alessandro Rubini <rubini at unipv.it>
> 
> Signed-off-by: Alessandro Rubini <rubini at unipv.it>
> Acked-by: Andrea Gallo <andrea.gallo at stericsson.com>

Please see previous comments about coding style.

Additionally:

> +int nhk8815_keypad_init(void)
> +{
> +        struct stdio_dev dev;

Indentation by TAB only, please.

> +	printf("%s:%s\n", __FILE__, __func__);

Guess this should be debug() instead?



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As long as we're going to reinvent the wheel again, we might as  well
try making it round this time.                        - Mike Dennison