[U-Boot] [PATCH] memsize: get correct memory size

[Wolfgang Denk]

Dear Minkyu Kang,

In message <1f3430fb0911222304pa45554epc7e46c49a9cc70f7 at mail.gmail.com> you wrote:
> 
> > In some case, saved address and compared address are different. (e.g: 80M)
> > So, it can be get wrong memory size.

Well, could you please explain what "some cases" are, and how exactly
the code is failing for you? And especially, what "80M" has to do with
it?

I guess you are aware that the code silently assumes that the size of
any memory bank is always a power of two, aren't you? So a size of
"80M" does not make any sense to me. If you have such a memory
configuration, it is most probably assembled from two separate memory
banks (64 + 16 MB), which of course need to be sized independently.


> > This patch fix the such problem, and fix style problems also.
...
> Any comments?

Frankly, I don't understand which problem you're trying to fix, nor
what your fix is supposed to be, nor your changes.

I don't want to imply that your patch is bad, but I don't understand
it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Pig: An animal (Porcus omnivorous) closely allied to the  human  race
by  the splendor and vivacity of its appetite, which, however, is in-
ferior in scope, for it balks at pig.                - Ambrose Bierce