[U-Boot] [PATCH] POST: Remove duplicated post_hotkey_pressed() functions

[Wolfgang Denk]

Dear Stefan Roese,

In message <1256906335-6477-1-git-send-email-sr at denx.de> you wrote:
> This patch introduces a weak default function for post_hotkey_pressed(),
> returning 0, for boards without hotkey support. The long-running tests
> won't be started on those boards. This default function was implemented
> in many board directories. By implementing this weak default we can
> remove all those duplicate versions.
> 
> Boards with hotkey support, can override this weak default function
> by defining one in their board specific code.

Hm... but the implementations were actually different. Some boards
used ctrlc() so they would catch a (prebably previously pressed) ^C:

> --- a/board/amcc/katmai/katmai.c
> +++ b/board/amcc/katmai/katmai.c
...
> -int post_hotkeys_pressed(void)
> -{
> -	return (ctrlc());
> -}
> -#endif

...while others unconditionally return 09, without checking for ^C:

> --- a/board/amcc/kilauea/kilauea.c
> +++ b/board/amcc/kilauea/kilauea.c
...
> -int post_hotkeys_pressed(void)
> -{
> -	return 0;	/* No hotkeys supported */
> -}


Are you sure the suggested change does not change the behavious on any
of these boards?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nobody trips over mountains. It is the small pebble that  causes  you
to  stumble.  Pass all the pebbles in your path and you will find you
have crossed the mountain.