[U-Boot] [PATCH 8/8] nhk8815: added lcd support

Alessandro Rubini rubini-list at gnudd.com
Wed Nov 25 16:23:26 CET 2009


I'm almost done with the requested changes on this patch set, will post
V2 this evening after re-running ./makeall as needed.

I've a question, though:

>> +extern int nhk8815_backlight_on(void);		/* in ./lcd.c */
> 
> Please move prototype decl;arations to some header file.

Unfortunately, there is no suitable file. It's just that I split
code related to different drivers in different files, for better
housekeeping.  These two are called nhk8815-something as they are
board-specific anyways.

Should I create a local header file in this same board directory, with
just the two prototypes? Or "ifndef __ASSEMBLY__ in the board config
file is better?  I'd better ask first to avoid a V3 just for this
detail.

Thanks
/alessandro


More information about the U-Boot mailing list