[U-Boot] [PATCH V2 0/9] display and keypad support for nhk8815
Alessandro Rubini
rubini-list at gnudd.com
Wed Nov 25 22:46:21 CET 2009
This patch set implements display and keypad support. To turn the display
on I need the STMPE2401 port expander, set up as a separate driver in this
patch set.
It's the same set I sent for RFC on Oct 9 2009, with the requested
fixes. I also added commit messages to each of them, and an initial
nhk-specific patch that was not submitted for RFC.
Detailed list of changes from V1 (as well as fixed message-id):
1/9 (nhk8815: fix i2c and other gpios at board_init time, not later):
new patch, needed to apply the other ones.
Please note that there is a block with local variables;
I know it is generally not advisable but they are really of
strictly local use, I think they deserve their limited scope.
2/9 (video: add amba-clcd prime-cell):
include/amba_clcd.h: fixed white space (spaces before tab)
better comments on the data structures
3/9 (include/nomadik.h: add physical address for cldc):
unchanged
4/9 (drivers/misc: add stmpe2401 port extender and keypad controller):
drivers/misc/stmpe2401.c: newlined all statements of if/else
include/stmpe2401.h: white space fixes
====> Note: I did not turn it into a C structure, as those registers
are I2C registers, so they are plain numbers, not offsets in
an I/O memory region where I use readl/writel
5/9 (nhk8815.h: define we need stmpe):
unchanged
6/9 (lcd: make 16bpp work):
declared the new "d" pointer in new ifdef block. I dislike it, but
my previous approach to avoid the ifdef was nacked. common/lcd.c is
a mess, unfortunately.
I made "./MAKEALL arm" and "./MAKEALL ppc" with no adverse effects.
7/9 (nhk8815: added keypad):
layout (space, if blocks)
removed extra __LINE__ temporary printouts
added an header for local prototypes
8/9 (nhk8815: start lower in RAM, so the 800x480 frame buffer fits):
changed the comment in config.mk.
9/9 (nhk8815: added lcd support):
white space changes (tabified the structures)
removed the __LINE__ temporary printouts
used the header introduced in 7/9 for local prototypes
Alessandro Rubini (9):
nhk8815: change the order of initialization
video: add amba-clcd prime-cell
include/nomadik.h: add physical address for cldc
drivers/misc: add stmpe2401 port extender and keypad controller
nhk8815.h: define we need stmpe
lcd: make 16bpp work
nhk8815: added keypad
nhk8815: start lower in RAM, so the 800x480 frame buffer fits
nhk8815: added lcd support
board/st/nhk8815/Makefile | 6 +-
board/st/nhk8815/config.mk | 8 +-
board/st/nhk8815/keypad.c | 99 +++++++++++++++++++
board/st/nhk8815/lcd.c | 87 ++++++++++++++++
board/st/nhk8815/nhk8815-devices.h | 8 ++
board/st/nhk8815/nhk8815.c | 38 +++++--
common/lcd.c | 27 ++++-
drivers/misc/Makefile | 1 +
drivers/misc/stmpe2401.c | 191 ++++++++++++++++++++++++++++++++++++
drivers/video/Makefile | 1 +
drivers/video/amba.c | 86 ++++++++++++++++
include/amba_clcd.h | 85 ++++++++++++++++
include/configs/nhk8815.h | 20 ++++-
include/nomadik.h | 1 +
include/stmpe2401.h | 66 ++++++++++++
15 files changed, 701 insertions(+), 23 deletions(-)
create mode 100644 board/st/nhk8815/keypad.c
create mode 100644 board/st/nhk8815/lcd.c
create mode 100644 board/st/nhk8815/nhk8815-devices.h
create mode 100644 drivers/misc/stmpe2401.c
create mode 100644 drivers/video/amba.c
create mode 100644 include/amba_clcd.h
create mode 100644 include/stmpe2401.h
More information about the U-Boot
mailing list