[U-Boot] [PATCH] samsung: fix DMC1_MEM_CFG for s3c64xx

"Seunghyeon Rhee (이승현)" seunghyeon at lpmtec.com
Sat Nov 28 02:26:33 CET 2009


The MSB of DMC1_MEM_CFG can be set to '1' for separate CKE control
for S3C6400. In the configuration of SMDK6400, however, two 16-bit
mDDR (SAMSUNG K4X51163) chips are used in parallel to form 32-bit
memory bus and there is no need to contorl CKE for each chip
separately. AFAIK, CKE1 is not at all connected. Only CKE0 is
used. Futhermore, it should be '0' always for S3C6410. When tested
with a board which has a S3C6410 and the same memory configuration,
a side effect is obsearved that u-boot command "reset" doesn't work
leading to system hang. Leaving the bit clear is safe in most cases.

Signed-off-by: Seunghyeon Rhee <seunghyeon at lpmtec.com>
---
 include/s3c6400.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/s3c6400.h b/include/s3c6400.h
index e527c08..7229ea6 100644
--- a/include/s3c6400.h
+++ b/include/s3c6400.h
@@ -817,7 +817,7 @@
 /*-----------------------------------------------------------------------
  * Physical Memory Map
  */
-#define DMC1_MEM_CFG	0x80010012	/* Chip1, Burst4, Row/Column bit */
+#define DMC1_MEM_CFG	0x00010012	/* Chip1, Burst4, Row/Column bit */
 #define DMC1_MEM_CFG2	0xB45
 #define DMC1_CHIP0_CFG	0x150F8		/* 0x4000_0000 ~ 0x43ff_ffff (64MB) */
 #define DMC_DDR_32_CFG	0x0 		/* 32bit, DDR */
-- 
1.6.2.5


-- 
Seunghyeon Rhee, Ph.D. / Director
LPM Technology Inc.
T +82-70-8255-6007  F +82-2-6442-6462
M +82-10-2790-0657


More information about the U-Boot mailing list