[U-Boot] [u-boot] [PATCH] [2/2] mxc_fec: put freed pointers to NULL to avoid problems with further free() calls.

[javier Martin]

2009/10/19 Wolfgang Denk <wd at denx.de>:
> Dear javier Martin,
>
> In message <eedb5540910190519l4551493eoc595ca39f0335cb2 at mail.gmail.com> you wrote:
>> If a free() call is used on an already freed pointer we run into
>> stability problems.
>
> Is this actually the case anywhere in the code? If so, that code
> should be fixed, as thisis obviously a bug then.
>
> I dislike workarounds like these as they just hush up design and/or
> implementation issues int he code. lease rather fix the real problems
> instead.
>
> Thanks.

You are right.

>
>> Tested on i.MX27 Litekit board with eldk-2.0 toolchain.
>
> ELDK 2.0? Wow. I did not think this was still in use anywhere around.

This is obviously a typo, I used eldk-4.2.

> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> "Most people would like to be delivered  from  temptation  but  would
> like it to keep in touch."                             - Robert Orben
>

Thank you for your comments, I will resent this patch fixing the real problem.

-- 
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com