[U-Boot] [PATCH] qemu_mips: Fix CONFIG_NET_MULTI build warning
Shinya Kuribayashi
skuribay at pobox.com
Mon Oct 19 15:04:39 CEST 2009
eth.c:497:2: warning: #warning Ethernet driver is deprecated. Please update to use CONFIG_NET_MULTI
Signed-off-by: Shinya Kuribayashi <skuribay at pobox.com>
---
I have a few concerns about this fix:
First. I'm not sure why CONFIG_NET_MULTI is "undef"ed for qemu_mips,
while CONFIG_DRIVER_NE2000 has been enabled for qemu_mips at an early
stage.
I don't follow recent changes around eth.c and CONFIG_NET_MULTI, but
it's probably CONFIG_NET_MULTI used to be used strictly for multi
ports, isn't it?
Next. As far as looking at drivers/net/ne2000*.[ch], NE2000 driver
doesn't seem to require board_eth_init() or cpu_eth_init(). Right?
Therefore I've not added a corresponding hook in board/qemu_mips/
qemu_mips.c. If my understanding is wrong, please let me know.
include/configs/qemu-mips.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/configs/qemu-mips.h b/include/configs/qemu-mips.h
index cbacdf9..f419174 100644
--- a/include/configs/qemu-mips.h
+++ b/include/configs/qemu-mips.h
@@ -157,7 +157,7 @@
#define CONFIG_ENV_OVERWRITE 1
-#undef CONFIG_NET_MULTI
+#define CONFIG_NET_MULTI
#define MEM_SIZE 128
--
1.6.5.1
More information about the U-Boot
mailing list