[U-Boot] [PATCH] Add common code dir for Matrix Vision boards.

[André Schwarz]

Wolfgang,

On Mon, 2009-08-31 at 20:26 +0200, Wolfgang Denk wrote:
> Dear Andre Schwarz,
> 
> In message <1251728304-26888-1-git-send-email-andre.schwarz at matrix-vision.de> you wrote:
> > This fixes current build failure.
> > 
> > Signed-off-by: Andre Schwarz <andre.schwarz at matrix-vision.de>
> 
> Hm... You did not test your patch, did you?

of course. Both boards compiled cleanly (I thought).

> 
> -> git-am -3 -i -u --whitespace=strip ~/Mail/U-Boot/8023

Sorry - I'm not familiar with this.

> Commit Body is:
> --------------------------
> Add common code dir for Matrix Vision boards.
> 
> This fixes current build failure.
> 
> Signed-off-by: Andre Schwarz <andre.schwarz at matrix-vision.de>
> --------------------------
> Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
> Applying: Add common code dir for Matrix Vision boards.
> /home/wd/git/u-boot/work/.git/rebase-apply/patch:168: trailing whitespace.

huh - need to do better checking.

> 
> warning: 1 line applied after fixing whitespace errors.
> ...
> Configuring for MVBLM7 board...
> mvblm7.c: In function 'misc_init_r':
> mvblm7.c:108: warning: implicit declaration of function 'mv_reset_environment'

ok - I can see it also on my build. Missed it yesterday.

> 
> 
> I'm a bit disappointed that this warning is still present. I think  I
> pointed it out before...

yes ... and I'm very uncomfortable with this. Don't know how this could
have slipped through. I greatly appreciate your help and will try to
improve.

> 
> OK, I fixed it for you.

Thank you.

> 
> Best regards,
> 
> Wolfgang Denk
> 

Regards,
André


MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich