[U-Boot] [PATCH 4/4] s5pc1xx: add support SMDKC100 board

[Wolfgang Denk]

Dear Kyungmin Park,

In message <9c9fda240909040409u576a7149kd4a4666148bfafa7 at mail.gmail.com> you wrote:
>
> >> +++ b/board/samsung/smdkc100/mem_setup.S
> >
> > Why is this all written in assembly code?
> >
> > Cannot we use C instead?
> 
> Since it is used at OneNAND IPL. It has size limitation.

So what?  Do you think that equivalent C code would be inherently
bigger? I am not so sure about that.

...
> >> +/***********************************************************
> >> + * Command definition
> >> + ***********************************************************/
> >> +#include <config_cmd_default.h>
> >> +
> >> +#undef CONFIG_CMD_LOADB
> >> +#undef CONFIG_CMD_LOADS
> >> +#undef CONFIG_CMD_BOOTD
> >> +#undef CONFIG_CMD_FPGA
> >> +#undef CONFIG_CMD_XIMG
> >> +#undef CONFIG_CMD_NAND
> >> +#undef CONFIG_CMD_IMLS
> >> +#undef CONFIG_CMD_FLASH
> >> +#undef CONFIG_CMD_IMLS
> >> +#undef CONFIG_CMD_NET
> >
> > Is there any specific reason for disabling these commands? Some of
> > these are extremely useful to the end user?
> 
> Since now we only tested on OneNAND. If someone or who want to use
> these feature just remove it at that time.

This makes no sense to me. Download commands like loadb and lods,
information commands like imls and network commands are completrely
independent of where you boot from.

It may make sense to diaable netwoirk support if you hav enot tested
it yet, but disabling all the othe rdefault features makes zero sense
to me. Please don't. Disable only things that really cannot be used.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The human race is a race of cowards; and I am not  only  marching  in
that procession but carrying a banner.                   - Mark Twain