[U-Boot] [PATCH] TI DaVinci: DM365: Minor Updates to DM365 EVM

[Wolfgang Denk]

Dear Sandeep,

In message <1252422547-27960-1-git-send-email-s-paulraj at ti.com> you wrote:
> From: Sandeep Paulraj <s-paulraj at ti.com>
> 
> The patch does the following
> 1) Gets rid of dependency on asm/sizes.h and replaces references
> to "SZ_xx" with their equivalent values

This is actually a good idea, I think. Yet I have some comments...


> diff --git a/board/davinci/dm365evm/dm365evm.c b/board/davinci/dm365evm/dm365evm.c
> index e30184b..1c88b30 100644
> --- a/board/davinci/dm365evm/dm365evm.c
> +++ b/board/davinci/dm365evm/dm365evm.c
> @@ -17,7 +17,7 @@
>  
>  #include <common.h>
>  #include <nand.h>
> -#include <linux/io.h>
> +#include <asm/io.h>

This is an unrelated fix, it seems. It should be split into a separate
commit.

> --- a/include/configs/davinci_dm365evm.h
> +++ b/include/configs/davinci_dm365evm.h
...
> @@ -38,7 +37,7 @@
>  /* Memory Info */
>  #define CONFIG_NR_DRAM_BANKS		1
>  #define PHYS_SDRAM_1			0x80000000
> -#define PHYS_SDRAM_1_SIZE		SZ_128M
> +#define PHYS_SDRAM_1_SIZE		0x08000000

I recommend to use a way to write such constants that can quickly read
(without much thinking) by a huan, for example here:

	#define PHYS_SDRAM_1_SIZE	(128 << 20)	/* 128 MiB */

Please consider adding a comment as I did to make it even easier to
understand.

> @@ -74,7 +73,6 @@
>  
>  /* NAND: socketed, two chipselects, normally 2 GBytes */
>  #define CONFIG_NAND_DAVINCI
> -#define CONFIG_SYS_NAND_HW_ECC

This is also an unrelated change that should be split into a separate
commit.

> @@ -125,7 +123,7 @@
>  #define CONFIG_SYS_LONGHELP
>  
>  #ifdef CONFIG_NAND_DAVINCI
> -#define CONFIG_ENV_SIZE		SZ_256K
> +#define CONFIG_ENV_SIZE		0x00040000

How about:

	#define CONFIG_ENV_SIZE		(256 << 10)	/* 256 KiB */

> @@ -143,8 +141,8 @@
>  #define CONFIG_TIMESTAMP
>  
>  /* U-Boot memory configuration */
> -#define CONFIG_STACKSIZE		SZ_256K		/* regular stack */
> -#define CONFIG_SYS_MALLOC_LEN		SZ_1M	/* malloc() arena */
> +#define CONFIG_STACKSIZE		0x00040000	/* regular stack */
> +#define CONFIG_SYS_MALLOC_LEN		0x00080000	/* malloc() arena */

	#define CONFIG_STACKSIZE	(256 << 10)	/* 256 KiB regular stack */
	#define CONFIG_SYS_MALLOC_LEN	(1 << 20)	/* 1 MiB malloc() arena */

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The optimum committee has no members.
                                                   - Norman Augustine