[U-Boot] [PATCH 01/10] mkconfig: parse top level makefile target to multiple config targets

Wolfgang Denk wd at denx.de
Tue Sep 8 19:46:29 CEST 2009


Dear Scott Wood,

In message <20090908153825.GA18061 at b07421-ec1.am.freescale.net> you wrote:
>
> > > #ifdef MPC8536DS_36BIT
> > > blablabla
> > > #endif
> > 
> > That would be CONFIG_MPC8536DS_NAND etc., but except of that that's
> > whaty I mean.
> 
> NAND and 36BIT are orthogonal options -- what is wrong with the previous
> suggestion of splitting them in mkconfig?

I don't like this idea as it will pollute the namespace by a number of
uncontrolled auto-generated #defines, which may be a nightmare to
debug because you quickly forget where such definitions might be
coming from - after you realize that they are actually set because you
cannot find them in any board-related config or source file.

There are a number of board names that have an underscore embedded
which may or may not indicate such options. Also, such auto-generated
symbols may be wrong. For example "omap1610inn_cs_autoboot_config"
would auto-generate

	CONFIG_OMAP1610INN
	CONFIG_CS
	CONFIG_AUTOBOOT

instead of the expected CONFIG_CS_AUTOBOOT

> With more than two orthogonal options, things will get rather silly
> trying to list every combination -- and it would be nice if it didn't
> matter which order the user specifies the options in.

Agreed. Unfortunately I don't have a clever idea how to implement
this either.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Always borrow money from a pessimist; they don't expect  to  be  paid
back.


More information about the U-Boot mailing list