[U-Boot] [PATCH] TI DaVinci: Remove references to SZ_xx
Jerry Van Baren
gerald.vanbaren at ge.com
Tue Sep 8 23:13:55 CEST 2009
Wolfgang Denk wrote:
> Dear "J.C. Wren",
>
> In message <17434f2e0909081312r3fe4523ej66ed4fc0275fa148 at mail.gmail.com> you wrote:
>> Excellent explanation. Thank you.
>
> Indeed. Thanks to gvb.
>
> I'd just like to add that you also never know if SZ_1M is 1024*1024 or 1000*1000.
>
>> I do like this (from the email link): (31 * 1024 * 1024). And it appears
>> not to give Wolfgang indigestion :)
>
> It is probably the preferred form in many cases, line length
> permitting :-) "31 << 20" is a bit shorter, but it's just a personal
s/3// ;-)
> preference, not something I consider better in any way.
>
> Best regards,
>
> Wolfgang Denk
Another objection: Company A makes their favorite SZ_* defines but
Company B defines them as SIZE_* but Company C defines them as...
...and we end up with the same mess as INT32 vs. WORD vs. int32_t
defines (C99 tackled that, finally, but not all the mess has been
cleaned up yet, 10 years later).
Best regards,
gvb
More information about the U-Boot
mailing list