[U-Boot] [PATCH 2/2] mucmc52, uc101: delete ata at 3a00 node, if no CF card is detected

Wolfgang Denk wd at denx.de
Wed Sep 9 11:03:23 CEST 2009


Dear Heiko Schocher,

In message <4AA7716C.3000003 at denx.de> you wrote:
> 
> > Hmm... that looks like duplicated identical code to me. Maybe we can
> > move this into a central location instead?
> 
> Hmm.. you are right, maybe cpu/mpc5xxx/cpu.c ft_cpu_setup() is
> a better place for it. And we can activate this through an
> CONFIG_OF_IDE_FIXUP define.

Sounds like a good idea to me, as I think that other boards may suffer
from the same problem. The suggested solution would keep the common
code unchanged and still allow all boards that need this to activate
it by a simple #define in the board config file.

The patch should then
- document the new CONFIG_ variable in the README,  and
- add a description of the problem that you are fixing to the commit
  message and the README, so others who look for solutions for the
  same problem can find it.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Der Horizont vieler Menschen ist ein Kreis mit Radius Null --
und das nennen sie ihren Standpunkt.


More information about the U-Boot mailing list