[U-Boot] [PATCH 1/2] mpc52xx, mucmc52, uc101: config cleanup

[Detlev Zundel]

Hi Heiko,

> - as this boards are similiar, collect common config option
>   in manroland-common.h
> - add OF support
> - update default environment
>
> Signed-off-by: Heiko Schocher <hs at denx.de>
> ---
>  board/mucmc52/mucmc52.c            |    7 +
>  board/uc101/uc101.c                |    7 +
>  include/configs/manroland-common.h |  336 ++++++++++++++++++++++++++++++++++++
>  include/configs/mucmc52.h          |  256 +--------------------------
>  include/configs/uc101.h            |  266 +---------------------------
>  5 files changed, 368 insertions(+), 504 deletions(-)
>  create mode 100644 include/configs/manroland-common.h

[...]

> + * High Level Configuration Options
> + * (easy to change)
> + */
> +#define CONFIG_MPC5xxx		1	/* This is an MPC5xxx CPU		*/
> +#define CONFIG_MPC5200		1	/* (more precisely an MPC5200 CPU)	*/
> +
> +#define CONFIG_SYS_MPC5XXX_CLKIN	33000000 /* ... running at 33.000000MHz	*/

Are you sure that this is a good choice to put in a manufacturer common
header file?  Isn't the probability of this becoming incorrect nearly
100% for the next board from this manufacturer?

I'd advise to keep CPU stuff in the individual board config files -
maybe, if you really want, create a "manroland-mpc52xx-common.h". The
rest of the common configs should be re-evaluated in the same spirit.

Cheers
  Detlev

-- 
LISP has  jokingly been  described as  "the most  intelligent way to  misuse a
computer".  I think that  description a great  compliment because it transmits
the full  flavour of  liberation:  it has assisted a number of our most gifted
fellow humans in thinking previously impossible thoughts. - Edsger W. Dijkstra
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de