[U-Boot] [PATCH] tools/netconsole: make a bit more robust and use ncb when possible

[Wolfgang Denk]

Dear Mike Frysinger,

In message <200909090846.33499.vapier at gentoo.org> you wrote:
>
> On Friday 09 January 2009 04:38:22 Mike Frysinger wrote:
> > The netcat utility likes to exit when it receives an empty packet (as it
> > thinks this means EOF).  This can easily occur when working with command
> > line editing as this behavior will be triggered when using backspace.  Or
> > with tabs and command line completion.  Since the local ncb util does not
> > have this "feature" and it supports broadcast udp, default to using that
> > rather than netcat.
> 
> ping ... afaik, it should still apply fine

Maybe. But I still don't like the patch. Now, with the distance of a
few months, I think it should be split into two parts:

1) "make a bit more robust"

I agree that this is kind of a bug fix; I think it can go in.

2) "use ncb when possible"

Here I really dislike the implementation of "when possible", which
makes silent and undocumented assumptions about from which directory
the script has to be run. I guess the "when possible" would almost
always turn out to be false, so we might omit the patch alltogether,
especially since it's also documented in "doc/README.NetConsole".

If we add it, we should follow standard UNIX philosophy and assume
that you set your PATH accordingly to reach the tools you want to use.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
While money can't buy happiness, it certainly lets  you  choose  your
own form of misery.