[U-Boot] [PATCH] tools/netconsole: make a bit more robust and use ncb when possible

[Wolfgang Denk]

Dear Mike Frysinger,

In message <200909091015.05454.vapier at gentoo.org> you wrote:
>
> > 2) "use ncb when possible"
> > 
> > Here I really dislike the implementation of "when possible", which
> > makes silent and undocumented assumptions about from which directory
> > the script has to be run. I guess the "when possible" would almost
> > always turn out to be false, so we might omit the patch alltogether,
> > especially since it's also documented in "doc/README.NetConsole".
> > 
> > If we add it, we should follow standard UNIX philosophy and assume
> > that you set your PATH accordingly to reach the tools you want to use.
>
> since ncb is compiled whenever netconsole is enabled, and people typically use 
> this script with netconsole enabled, "when possible" tends to be line up 
> fairly often.  also, the broadcast aspect is pretty useful.  i guess i could 

Agreed. But the code is based on the assumption that your current
directory when attaching to the console of a target is the U-Boot
source directory. For me, this is definitely not always the case. I
might as well have /tftpboot or solilar as cwd.

> make it search PATH, but the idea was to have things "just work" rather than 
> forcing people to install random utils into their PATH.

I rather have people intentionally install tools to some directory in
their PATH or set PATH intentionally to some tool directory rather
than have tools suddenly and mysteriously break just because I run
them from a different location.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You are in a maze of UUCP connections, all alike.