[U-Boot] [PATCH v4 5/5][repost] tools: mkimage: Add: Kirkwood Boot Image support (kwbimage)

Wolfgang Denk wd at denx.de
Thu Sep 10 12:38:56 CEST 2009


Dear Prafulla Wadaskar,

In message <1252316102-17977-1-git-send-email-prafulla at marvell.com> you wrote:
> This patch adds type kwbimage support for new mkimage core
> For more details refer docs/README.kwbimage
> 
> This patch is tested with Sheevaplug board
> 
> Signed-off-by: Prafulla Wadaskar <prafulla at marvell.com>
> Acked-by: Ron Lee <ron at debian.org>
> 
> Signed-off-by: Prafulla Wadaskar <prafulla at marvell.com>
> ---
> v2: updated as per review comments for v1
> added len checks in checksum functions
> added printable strings for each valid table entry
> use of sccanf not changed since it offers return value for failure
> 
> v3: resolved merge issues on mkimage branch
> 
> v4: added warning fix on amd64
>     Use an intermediate type as large as the pointers we do simple arithmetic with.
>     Use a format string type that suits the sizeof type from KWBIMAGE_MAX_CONFIG.
>     The compiler warns about both of these on amd64.
> included kwbimage.o in the build dependency calculations
> _GNU_SOURCE defined to obtain getline prototype from stdio.h
> most of these changes suggested by Ron Lee (in cc list)
> 
> v4 repost: typos corrected in commit message
> 
> 
>  Makefile            |    5 +
>  common/image.c      |    1 +
>  doc/README.kwbimage |   93 ++++++++++++
>  include/image.h     |    1 +
>  tools/Makefile      |    5 +
>  tools/kwbimage.c    |  405 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  tools/kwbimage.h    |  106 +++++++++++++
>  tools/mkimage.c     |    2 +
>  tools/mkimage.h     |    1 +
>  9 files changed, 619 insertions(+), 0 deletions(-)
>  create mode 100644 doc/README.kwbimage
>  create mode 100644 tools/kwbimage.c
>  create mode 100644 tools/kwbimage.h

Applied to "mkimage" branch, thanks.


Now this patch series has completely been added to the "mkimage"
branch, I would like to ask you to re-test everything. If it's working
for you and everybody else (or if nobody raises any concerns) I will
merge this branch into mainline in a few days.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"...this does not mean that some of us should not want, in  a  rather
dispassionate sort of way, to put a bullet through csh's head."
                   - Larry Wall in <1992Aug6.221512.5963 at netlabs.com>


More information about the U-Boot mailing list