[U-Boot] [PATCHv2 1/2] mpc52xx, mucmc52, uc101: config cleanup

[Heiko Schocher]

Hello Detlev,

Detlev Zundel wrote:
>> - as this boards are similiar, collect common config option
>>   in manroland-common.h and manroland-mpc52xx-common.h
>>   for mpc52xx specific common options for this manufacturer.
>> - add OF support
>> - update default environment
> 
> Argh, sorry for interrupting again, but I think I suggested something
> problematic on second thought:
> 
>>  include/configs/manroland-mpc52xx-common.h |  230 ++++++++++++++++++++++++
> 
> [...]
> 
>> diff --git a/include/configs/manroland-mpc52xx-common.h b/include/configs/manroland-mpc52xx-common.h
>> new file mode 100644
>> index 0000000..b29ef9b
>> --- /dev/null
>> +++ b/include/configs/manroland-mpc52xx-common.h
> 
> [...]
> 
>> +#define CONFIG_MPC5xxx		1	/* This is an MPC5xxx CPU		*/
>> +#define CONFIG_MPC5200		1	/* (more precisely an MPC5200 CPU)	*/
> 
> So all boards using manroland-mpc52xx-common.h are in fact 5200s.  In
> this case, I should have suggested the filename
> "manroland-mpc5200-common.h" as the "xx" part surely cannot be anything
> else then "00".

Argh.. and I didn;t detected it too ;-)

> Sorry for this wrong lead.

No problem, I send a patch soon, if the rest of this patch is ok.

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany