[U-Boot] [PATCH] ppc/85xx: Remove some bogus code from external interrupt handler.

Kumar Gala galak at kernel.crashing.org
Thu Sep 10 21:14:20 CEST 2009


From: Scott Wood <scottwood at freescale.com>

Skipping the interrupted instruction will accomplish nothing other
than turning a spurious interrupt into a crash.

External interrupts are not machine checks, so don't count them as such.

Signed-off-by: Scott Wood <scottwood at freescale.com>
---
 cpu/mpc85xx/traps.c |    9 +--------
 1 files changed, 1 insertions(+), 8 deletions(-)

diff --git a/cpu/mpc85xx/traps.c b/cpu/mpc85xx/traps.c
index 1045cc1..9d16b9b 100644
--- a/cpu/mpc85xx/traps.c
+++ b/cpu/mpc85xx/traps.c
@@ -287,6 +287,7 @@ UnknownException(struct pt_regs *regs)
 	       regs->nip, regs->msr, regs->trap);
 	_exception(0, regs);
 }
+
 void
 ExtIntException(struct pt_regs *regs)
 {
@@ -305,14 +306,6 @@ ExtIntException(struct pt_regs *regs)
 	printf(" irq IACK0@%05x=%d\n",(int)&pic->iack0,vect);
 	show_regs(regs);
 	print_backtrace((unsigned long *)regs->gpr[1]);
-	machinecheck_count++;
-#ifdef EXTINT_NOSKIP
-	printf("Returning back to 0x%08x\n",regs->nip);
-#else
-	regs->nip += 4; /* skip offending instruction */
-	printf("Skipping current instr, Returning to 0x%08lx\n",regs->nip);
-#endif
-
 }
 
 void
-- 
1.6.0.6



More information about the U-Boot mailing list