[U-Boot] [PATCH v2 3/5] NAND boot: MPC8536DS support

[Kumar Gala]

On Sep 11, 2009, at 12:43 AM, Hu Mingkai-B21284 wrote:

>
>
>> -----Original Message-----
>> From: Kumar Gala [mailto:galak at kernel.crashing.org]
>> Sent: Friday, September 11, 2009 12:21 PM
>> To: Gala Kumar-B11780
>> Cc: Hu Mingkai-B21284; Wood Scott-B07421; u-boot at lists.denx.de
>> Subject: Re: [U-Boot] [PATCH v2 3/5] NAND boot: MPC8536DS support
>>
>>
>> On Sep 10, 2009, at 11:11 PM, Kumar Gala wrote:
>>
>>>
>>> On Sep 10, 2009, at 9:53 PM, Mingkai Hu wrote:
>>>
>>>> board/freescale/mpc8536ds/u-boot-nand.lds      |  140
>> +++++++++++++++
>>>> +++++++++
>>>
>>> Do we really need a specific linker script for this?
>>
>> More specifically, can we move it into
>> cpu/mpc85xx/u-boot-nand.lds and match cpu/mpc85xx/u-boot.lds.
>>
>
> I think it can be moved to cpu/mpc85xx/*, but it's a little trouble to
> match u-boot.lds
> when load the boot-from-nand image to L2 SRAM.
>
> The script u-boot.lds will expand the image to 512K, along with the 4K
> NAND loader,
> the image size wil over 512K, so we place the boot page on the  
> beginning
> of the
> boot-from-nand image.
>
> When load the image to DDR, I think it can match u-boot.lds.

When I say match I just meant the differences should only be the one's  
required.

For example I don't believe this difference is necessary:

@@ -69,8 +65,10 @@
      PROVIDE (etext = .);
      .rodata    :
     {
+    *(.rodata)
+    *(.rodata1)
+    *(.rodata.str1.4)
      *(.eh_frame)
-    *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*)))
    } :text
    .fini      : { *(.fini)    } =0
    .ctors     : { *(.ctors)   }

- k