[U-Boot] [PATCH v4 2/2] mucmc52, uc101: delete ata at 3a00 node, if no CF card is detected

[Heiko Schocher]

Hello Stefan,

Stefan Roese wrote:
> On Monday 14 September 2009 17:55:01 Heiko Schocher wrote:
>>>>> Incorrect multi-line parentheses:
>>>>>
>>>>> 		if (nodeoffset >= 0) {
>>>>> 			fdt_del_node(blob, nodeoffset);
>>>>> 		} else {
>>>>> 			printf("%s: cannot find %s node err:%s\n",
>>>>> 				__func__, nodename, fdt_strerror(nodeoffset));
>>>>> 		}
>>>>                 if (nodeoffset >= 0)
>>>>                         fdt_del_node(blob, nodeoffset);
>>>>                 else
>>>>                         printf("%s: cannot find %s node err:%s\n",
>>>>                                 __func__, nodename,
>>>>  fdt_strerror(nodeoffset));
>>>>
>>>> Should be right, or?
>>> No. IIRC, then when one of the statements is a multi-line statement, both
>>> statements of the if/else struct should have the parentheses.
>> I see only one statement in the if and the else case ...
> 
> Yes, but it spans over multiple (2) lines. So it's a multi-line statement. At 
> least that's how I understand the coding-style docs.

Ah, okay, fixed it.

tschuess
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany