[U-Boot] autoscr command failure saveenv dataflash

Wolfgang Denk wd at denx.de
Tue Sep 15 22:37:57 CEST 2009


Dear "Berns",

In message <NDBBKLDECLOIHFJKBINAGECGEKAA.Berns at BEKA-Elektronik.de> you wrote:
> 
> the reason for this problem is the definition of
> 
> #define DATAFLASH_BUSY			0x00
> #define DATAFLASH_OK			0x01
> in the file /include/dataflash.h.
> 
> All functions return DATAFLASH_OK and in the file /common/cmd_nvedit.c
> 
> function do_saveenv()
> 
> return (saveenv() ? 1 : 0);
> 
> than cause an error.
> 
> I have modified it to return (saveenv() == 1 ? 0 : 1);
> 
> and this works for my, but i'am not sure if this is the best way of fixing
> the problem.

Can you please submit this as a patch (including your SoB-Line), so we
can chek it?

Please see http://www.denx.de/wiki/U-Boot/Patches for details.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"(The  Chief  Programmer)  personally  defines  the  functional   and
performance  specifications, designs the program, codes it, tests it,
and writes its documentation... He  needs  great  talent,  ten  years
experience  and  considerable  systems  and  applications  knowledge,
whether in applied mathematics, business data handling, or whatever."
- Fred P. Brooks, _The Mythical Man Month_


More information about the U-Boot mailing list